Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement](sequence col) add session variable to skip sequence column check while INSERT INTO #41655

Merged

Conversation

zhannngchen
Copy link
Contributor

@zhannngchen zhannngchen commented Oct 10, 2024

Proposed changes

Issue Number: close #xxx

For unique key tables using a sequence column, the INSERT INTO operation requires a sequence value to be provided for each row.
This PR add a new session variable require_sequence_in_insert to control this behavior.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhannngchen zhannngchen force-pushed the fix-insert-into-select-with-seq-col branch from 551d6b5 to 85fe1c6 Compare October 10, 2024 08:05
"For unique key tables using a sequence column, the INSERT INTO operation requires a sequence value"
+ " to be provided for each row. When this variable is enabled, the check will be skipped"
})
public boolean skipInsertSequenceCheck = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to use enableInsertSequenceCheck instead

gavinchou
gavinchou previously approved these changes Oct 10, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 10, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@zhannngchen
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 10, 2024
@zhannngchen
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2024
@zhannngchen zhannngchen merged commit df3a3ab into apache:master Oct 11, 2024
26 of 28 checks passed
zhannngchen added a commit to zhannngchen/incubator-doris that referenced this pull request Oct 11, 2024
…umn check while INSERT INTO (apache#41655)

For unique key tables using a sequence column, the `INSERT INTO`
operation requires a sequence value to be provided for each row.
This PR add a new session variable `require_sequence_in_insert` to
control this behavior.
zhannngchen added a commit to zhannngchen/incubator-doris that referenced this pull request Oct 11, 2024
…umn check while INSERT INTO (apache#41655)

For unique key tables using a sequence column, the `INSERT INTO`
operation requires a sequence value to be provided for each row.
This PR add a new session variable `require_sequence_in_insert` to
control this behavior.
zhannngchen added a commit that referenced this pull request Oct 12, 2024
zhannngchen added a commit that referenced this pull request Oct 12, 2024
dataroaring pushed a commit that referenced this pull request Oct 20, 2024
…umn check while INSERT INTO (#41655) (#42030)

cherry-pick #41655

For unique key tables using a sequence column, the `INSERT INTO`
operation requires a sequence value to be provided for each row. This PR
add a new session variable `require_sequence_in_insert` to control this
behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants